Merge pull request #504 from GitLiveApp/make-android-ios-js-properties-extensions

[BREAKING CHANGE] refactor .js, .android, .ios properties extensions

Author: nbransby

README.md

@@ -259,7 +259,7 @@ It uses the <a href="https://github.com/GitLiveApp/firebase-java-sdk">Firebase J
 
 ### Accessing the underlying Firebase SDK
 
-In some cases you might want to access the underlying official Firebase SDK in platform specific code, for example when the common API is missing the functionality you need. For this purpose each class in the SDK has `android`, `ios` and `js` properties which holds the  equivalent object of the underlying official Firebase SDK. For *JVM*, as the `firebase-java-sdk` is a direct port of the Firebase Android SDK, is it also accessed via the `android` property.
+In some cases you might want to access the underlying official Firebase SDK in platform specific code, for example when the common API is missing the functionality you need. For this purpose each class in the SDK has `android`, `ios` and `js` extension properties that hold the equivalent object of the underlying official Firebase SDK. For *JVM*, as the `firebase-java-sdk` is a direct port of the Firebase Android SDK, is it also accessed via the `android` property.
 
 These properties are only accessible from the equivalent target's source set. For example to disable persistence in Cloud Firestore on Android you can write the following in your Android specific code (e.g. `androidMain` or `androidTest`):
 

firebase-analytics/api/android/firebase-analytics.api

@@ -12,7 +12,6 @@ public final class dev/gitlive/firebase/analytics/AnalyticsKt {
 
 public final class dev/gitlive/firebase/analytics/FirebaseAnalytics {
 	public fun <init> (Lcom/google/firebase/analytics/FirebaseAnalytics;)V
-	public final fun getAndroid ()Lcom/google/firebase/analytics/FirebaseAnalytics;
 	public final fun getSessionId (Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
 	public final fun logEvent (Ljava/lang/String;Ljava/util/Map;)V
 	public static synthetic fun logEvent$default (Ldev/gitlive/firebase/analytics/FirebaseAnalytics;Ljava/lang/String;Ljava/util/Map;ILjava/lang/Object;)V
@@ -207,5 +206,6 @@ public final class dev/gitlive/firebase/analytics/FirebaseAnalyticsUserProperty
 public final class dev/gitlive/firebase/analytics/analyticsAndroid {
 	public static final fun analytics (Ldev/gitlive/firebase/Firebase;Ldev/gitlive/firebase/FirebaseApp;)Ldev/gitlive/firebase/analytics/FirebaseAnalytics;
 	public static final fun getAnalytics (Ldev/gitlive/firebase/Firebase;)Ldev/gitlive/firebase/analytics/FirebaseAnalytics;
+	public static final fun getAndroid (Ldev/gitlive/firebase/analytics/FirebaseAnalytics;)Lcom/google/firebase/analytics/FirebaseAnalytics;
 }
 

firebase-analytics/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlive/firebase-analytics",
-  "version": "1.13.0",
+  "version": "2.0.0",
   "description": "Wrapper around firebase for usage in Kotlin Multiplatform projects",
   "main": "firebase-analytics.js",
   "scripts": {
@@ -23,7 +23,7 @@
   },
   "homepage": "https://github.com/GitLiveApp/firebase-kotlin-sdk",
   "dependencies": {
-    "@gitlive/firebase-app": "1.13.0",
+    "@gitlive/firebase-app": "2.0.0",
     "firebase": "9.19.1",
     "kotlin": "1.6.10",
     "kotlinx-coroutines-core": "1.6.1-native-mt"

firebase-analytics/src/androidMain/kotlin/dev/gitlive/firebase/analytics/analytics.kt

@@ -16,7 +16,9 @@ public actual val Firebase.analytics: FirebaseAnalytics
 public actual fun Firebase.analytics(app: FirebaseApp): FirebaseAnalytics =
     FirebaseAnalytics(com.google.firebase.Firebase.analytics)
 
-public actual class FirebaseAnalytics(public val android: com.google.firebase.analytics.FirebaseAnalytics) {
+public val FirebaseAnalytics.android: com.google.firebase.analytics.FirebaseAnalytics get() = android
+
+public actual class FirebaseAnalytics(internal val android: com.google.firebase.analytics.FirebaseAnalytics) {
     public actual fun logEvent(name: String, parameters: Map<String, Any>?) {
         android.logEvent(name, parameters?.toBundle())
     }

firebase-analytics/src/iosMain/kotlin/dev/gitlive/firebase/analytics/analytics.kt

@@ -15,7 +15,9 @@ public actual val Firebase.analytics: FirebaseAnalytics
 
 public actual fun Firebase.analytics(app: FirebaseApp): FirebaseAnalytics = FirebaseAnalytics(FIRAnalytics)
 
-public actual class FirebaseAnalytics(public val ios: FIRAnalytics.Companion) {
+public val FirebaseAnalytics.ios: FIRAnalytics.Companion get() = ios
+
+public actual class FirebaseAnalytics(internal val ios: FIRAnalytics.Companion) {
     public actual fun logEvent(name: String, parameters: Map<String, Any>?) {
         val mappedParameters: Map<Any?, Any>? = parameters?.map { it.key to it.value }?.toMap()
         ios.logEventWithName(name, mappedParameters)

firebase-analytics/src/jsMain/kotlin/dev/gitlive/firebase/analytics/analytics.kt

@@ -4,6 +4,7 @@ import dev.gitlive.firebase.Firebase
 import dev.gitlive.firebase.FirebaseApp
 import dev.gitlive.firebase.FirebaseException
 import dev.gitlive.firebase.analytics.externals.getAnalytics
+import dev.gitlive.firebase.js
 import kotlinx.coroutines.await
 import kotlin.time.Duration
 
@@ -13,7 +14,9 @@ public actual val Firebase.analytics: FirebaseAnalytics
 public actual fun Firebase.analytics(app: FirebaseApp): FirebaseAnalytics =
     FirebaseAnalytics(getAnalytics(app.js))
 
-public actual class FirebaseAnalytics(public val js: dev.gitlive.firebase.analytics.externals.FirebaseAnalytics) {
+public val FirebaseAnalytics.js: dev.gitlive.firebase.analytics.externals.FirebaseAnalytics get() = js
+
+public actual class FirebaseAnalytics(internal val js: dev.gitlive.firebase.analytics.externals.FirebaseAnalytics) {
     public actual fun logEvent(
         name: String,
         parameters: Map<String, Any>?,

firebase-app/api/android/firebase-app.api

@@ -7,12 +7,10 @@ public final class dev/gitlive/firebase/Firebase {
 }
 
 public final class dev/gitlive/firebase/FirebaseApp {
-	public final fun component1 ()Lcom/google/firebase/FirebaseApp;
 	public final fun copy (Lcom/google/firebase/FirebaseApp;)Ldev/gitlive/firebase/FirebaseApp;
 	public static synthetic fun copy$default (Ldev/gitlive/firebase/FirebaseApp;Lcom/google/firebase/FirebaseApp;ILjava/lang/Object;)Ldev/gitlive/firebase/FirebaseApp;
 	public final fun delete (Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
 	public fun equals (Ljava/lang/Object;)Z
-	public final fun getAndroid ()Lcom/google/firebase/FirebaseApp;
 	public final fun getName ()Ljava/lang/String;
 	public final fun getOptions ()Ldev/gitlive/firebase/FirebaseOptions;
 	public fun hashCode ()I
@@ -23,6 +21,7 @@ public final class dev/gitlive/firebase/FirebaseKt {
 	public static final fun app (Ldev/gitlive/firebase/Firebase;Ljava/lang/String;)Ldev/gitlive/firebase/FirebaseApp;
 	public static final fun apps (Ldev/gitlive/firebase/Firebase;Ljava/lang/Object;)Ljava/util/List;
 	public static synthetic fun apps$default (Ldev/gitlive/firebase/Firebase;Ljava/lang/Object;ILjava/lang/Object;)Ljava/util/List;
+	public static final fun getAndroid (Ldev/gitlive/firebase/FirebaseApp;)Lcom/google/firebase/FirebaseApp;
 	public static final fun getApp (Ldev/gitlive/firebase/Firebase;)Ldev/gitlive/firebase/FirebaseApp;
 	public static final fun initialize (Ldev/gitlive/firebase/Firebase;Ljava/lang/Object;)Ldev/gitlive/firebase/FirebaseApp;
 	public static final fun initialize (Ldev/gitlive/firebase/Firebase;Ljava/lang/Object;Ldev/gitlive/firebase/FirebaseOptions;)Ldev/gitlive/firebase/FirebaseApp;

firebase-app/api/jvm/firebase-app.api

@@ -7,12 +7,10 @@ public final class dev/gitlive/firebase/Firebase {
 }
 
 public final class dev/gitlive/firebase/FirebaseApp {
-	public final fun component1 ()Lcom/google/firebase/FirebaseApp;
 	public final fun copy (Lcom/google/firebase/FirebaseApp;)Ldev/gitlive/firebase/FirebaseApp;
 	public static synthetic fun copy$default (Ldev/gitlive/firebase/FirebaseApp;Lcom/google/firebase/FirebaseApp;ILjava/lang/Object;)Ldev/gitlive/firebase/FirebaseApp;
 	public final fun delete (Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
 	public fun equals (Ljava/lang/Object;)Z
-	public final fun getAndroid ()Lcom/google/firebase/FirebaseApp;
 	public final fun getName ()Ljava/lang/String;
 	public final fun getOptions ()Ldev/gitlive/firebase/FirebaseOptions;
 	public fun hashCode ()I
@@ -23,6 +21,7 @@ public final class dev/gitlive/firebase/FirebaseKt {
 	public static final fun app (Ldev/gitlive/firebase/Firebase;Ljava/lang/String;)Ldev/gitlive/firebase/FirebaseApp;
 	public static final fun apps (Ldev/gitlive/firebase/Firebase;Ljava/lang/Object;)Ljava/util/List;
 	public static synthetic fun apps$default (Ldev/gitlive/firebase/Firebase;Ljava/lang/Object;ILjava/lang/Object;)Ljava/util/List;
+	public static final fun getAndroid (Ldev/gitlive/firebase/FirebaseApp;)Lcom/google/firebase/FirebaseApp;
 	public static final fun getApp (Ldev/gitlive/firebase/Firebase;)Ldev/gitlive/firebase/FirebaseApp;
 	public static final fun initialize (Ldev/gitlive/firebase/Firebase;Ljava/lang/Object;)Ldev/gitlive/firebase/FirebaseApp;
 	public static final fun initialize (Ldev/gitlive/firebase/Firebase;Ljava/lang/Object;Ldev/gitlive/firebase/FirebaseOptions;)Ldev/gitlive/firebase/FirebaseApp;

firebase-app/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlive/firebase-app",
-  "version": "1.13.0",
+  "version": "2.0.0",
   "description": "Wrapper around firebase for usage in Kotlin Multiplatform projects",
   "main": "firebase-app.js",
   "scripts": {
@@ -23,7 +23,7 @@
   },
   "homepage": "https://github.com/GitLiveApp/firebase-kotlin-sdk",
   "dependencies": {
-    "@gitlive/firebase-common": "1.13.0",
+    "@gitlive/firebase-common": "2.0.0",
     "firebase": "9.19.1",
     "kotlin": "1.8.20",
     "kotlinx-coroutines-core": "1.6.4"

firebase-app/src/androidMain/kotlin/dev/gitlive/firebase/firebase.kt

@@ -14,6 +14,8 @@ public actual typealias FirebaseTooManyRequestsException = com.google.firebase.F
 
 public actual typealias FirebaseApiNotAvailableException = com.google.firebase.FirebaseApiNotAvailableException
 
+public val FirebaseApp.android: com.google.firebase.FirebaseApp get() = android
+
 public actual val Firebase.app: FirebaseApp
     get() = FirebaseApp(com.google.firebase.FirebaseApp.getInstance())
 
@@ -29,7 +31,7 @@ public actual fun Firebase.initialize(context: Any?, options: FirebaseOptions, n
 public actual fun Firebase.initialize(context: Any?, options: FirebaseOptions): FirebaseApp =
     FirebaseApp(com.google.firebase.FirebaseApp.initializeApp(context as Context, options.toAndroid()))
 
-public actual data class FirebaseApp internal constructor(val android: com.google.firebase.FirebaseApp) {
+public actual data class FirebaseApp internal constructor(internal val android: com.google.firebase.FirebaseApp) {
     actual val name: String
         get() = android.name
     actual val options: FirebaseOptions