Skip to content

Commit 4cb3481

Browse files
authored
feat(Engine): Evaluate from EvaluationContext (#108)
* Introduce context values evaluation data model * Update engine test data * Get ready for engine tests * Introduce new engine * Lint ✨ * Make priority clearer * Update EvaluationResult spec Contributes to Flagsmith/flagsmith#6121 * yay * Fix identity traits data type * Update engine test data branch * Fix identity as an optional context * Improve API * Make code reusable * Apples will never be bananas * Track TODO with an issue #110 * Improve type handling in the IN operator * Make MODULO check less prone to error * Fix obtaining a context value * Update comment to latest reality * Delete skippable code * Update test cases * Fix tests * Carry segment metadata around * Please run tests (cherry picked from commit 2913611) * Comply with latest test data * Ensure variants are selected consistently * Update tests
1 parent 28a1063 commit 4cb3481

19 files changed

+769
-55
lines changed

.github/workflows/pull-requests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ name: Flagsmith PHP Pull Request
22

33
on:
44
pull_request:
5-
branches:
6-
- main
7-
- release**
85

96
jobs:
107
test:

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
[submodule "tests/Engine/EngineTests/EngineTestData"]
22
path = tests/Engine/EngineTests/EngineTestData
33
url = git@github.com:Flagsmith/engine-test-data.git
4-
branch = v1.0.0
4+
tag = v2.4.0

composer.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,17 @@
1717
"psr/simple-cache": ">=1.0",
1818
"psr/http-factory-implementation": "1.0",
1919
"psr/http-client-implementation": "1.0",
20-
"psr/http-message-implementation": "1.0"
20+
"psr/http-message-implementation": "1.0",
21+
"softcreatr/jsonpath": "^0.10.0"
2122
},
2223
"require-dev": {
2324
"guzzlehttp/guzzle": "^7.3",
2425
"guzzlehttp/psr7": "^2.1.0",
2526
"phpunit/phpunit": "^9.5",
2627
"symfony/cache": "^5.4.6",
2728
"friendsofphp/php-cs-fixer": "^3.6",
28-
"doppiogancio/mocked-client": "^3.0"
29+
"doppiogancio/mocked-client": "^3.0",
30+
"colinodell/json5": "^3.0"
2931
},
3032
"autoload": {
3133
"psr-4": {

0 commit comments

Comments
 (0)