Skip to content

Commit 3e94f69

Browse files
committed
function+file names
1 parent b947a66 commit 3e94f69

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

tools/crash_test.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,10 @@ def Do(self):
9292
subprocess.run(Virtualize([PathJoin(BREAKPAD_DIR, "src/processor/minidump_stackwalk"), dump, SYMBOL_DIR]), check=True, stdout=sw_f, stderr=subprocess.STDOUT)
9393
sw_f.seek(0)
9494
sw = sw_f.read()
95-
TRACE_FUNC = "InjectFaultCmd::Run"
96-
self.Verify(TRACE_FUNC in sw, "function names not found in trace (did you build with symbols?)")
95+
# Check both function names and filenames. With the Unvanquished 0.55.2 release on Linux,
96+
# we get file:line info but not function names...
97+
self.Verify("CommandSystem.cpp" in sw, "source file names not found in trace")
98+
self.Verify("InjectFaultCmd::Run" in sw, "function names not found in trace")
9799

98100
def Virtualize(cmdline):
99101
bin, *args = cmdline

0 commit comments

Comments
 (0)