Merge branch 'ChromeDevTools:main' into main

Author: tysonthomas9

.vscode/devtools-workspace-tasks.json

@@ -24,6 +24,43 @@
           }
         }
       ]
+    },
+   {
+    "label": "Create Widget",
+    "type": "shell",
+    "command": "node",
+    "args": [
+      "${workspaceFolder}/scripts/scaffold/scaffold-widget.js",
+      "${input:widgetPath}",
+      "${input:widgetName}"
+    ],
+    "options": {
+      "cwd": "${workspaceFolder}"
+    },
+    "problemMatcher": [],
+    "presentation": {
+      "echo": true,
+      "reveal": "always",
+      "focus": false,
+      "panel": "shared",
+      "showReuseMessage": false,
+      "clear": false
+    },
+    "group": {
+      "kind": "build",
+      "isDefault": false
+    }
+  }],
+  "inputs": [
+    {
+      "id": "widgetPath",
+      "type": "promptString",
+      "description": "Enter the path to create the widget (e.g., front_end/panels/ai_assistance)"
+    },
+    {
+      "id": "widgetName",
+      "type": "promptString",
+      "description": "Enter the WidgetName (PascalCase, e.g., MyWidget)"
     }
   ]
 }

DEPS

@@ -15,24 +15,24 @@ vars = {
   'build_revision': 'e13953ced04ed05f45aa3c961bd6d802aced74ec',
 
   'buildtools_url': 'https://chromium.googlesource.com/chromium/src/buildtools.git',
-  'buildtools_revision': 'e9b36e9ffb02b268d194c3f82f89952d09d0c714',
+  'buildtools_revision': 'cd169314af80e77a75eb25e2c0df8798f35bc04a',
 
   'depot_tools_url': 'https://chromium.googlesource.com/chromium/tools/depot_tools.git',
-  'depot_tools_revision': 'f810dae27200e4209bd0cba85bd2266ec0d55312',
+  'depot_tools_revision': '0888983e473613d853c419245b97294e46497798',
 
   'inspector_protocol_url': 'https://chromium.googlesource.com/deps/inspector_protocol',
   'inspector_protocol_revision': '6d1ae0f13aae6ad381ca31b17b88a0f5af29ca94',
 
   # Keeping track of the last time we rollerd the browser protocol files.
-  'chromium_browser_protocol_revision' : 'f351d8b201937d9402701c01bb3ba07eb2001ae0',
+  'chromium_browser_protocol_revision' : '3313d9b6b84ff455dbf0edfee0bb15bbc23b30ba',
 
   'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
   'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',
 
   'emscripten_tag': 'ade9d780ff17c88d81aa13860361743e3c1e1396',
 
   # GN CIPD package version.
-  'gn_version': 'git_revision:0c25d1bbde6ef17e1e6d3938011f56a00c02e457',
+  'gn_version': 'git_revision:cad8f67e2dd0cea00bbe4566efe2fdf4c1821563',
 
   'cmake_version': 'version:2@3.21.3',
 
@@ -49,7 +49,7 @@ vars = {
   # Chrome version used for tests. It should be regularly updated to
   # match the Canary version listed here:
   # https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json
-  'chrome': '138.0.7182.0',
+  'chrome': '138.0.7190.0',
 
   # 'magic' text to tell depot_tools that git submodules should be accepted but
   # but parity with DEPS file is expected.
@@ -59,7 +59,7 @@ vars = {
   'non_git_source': 'True',
 
   # siso CIPD package version
-  'siso_version': 'git_revision:30ea210712239b874febcadf661f118fc2c0f6d7',
+  'siso_version': 'git_revision:d9393c2115244b6e4a797189055e4a2b6769a64d',
 }
 
 # Only these hosts are allowed for dependencies in this DEPS file.

buildtools

@@ -540,6 +540,8 @@ export default defineConfig([
       'no-array-constructor': 'off',
       '@typescript-eslint/no-array-constructor': 'error',
 
+      '@typescript-eslint/consistent-indexed-object-style': 'error',
+
       'rulesdir/no-underscored-properties': 'error',
       'rulesdir/inline-type-imports': 'error',
 

eslint.config.mjs

@@ -98,7 +98,7 @@ export class WorkerPlugin implements Chrome.DevTools.LanguageExtensionPlugin, As
 
 export interface Storage {
   onChanged: Chrome.DevTools
-      .EventSink<(changes: {[key: string]: {oldValue: unknown, newValue: unknown}}, namespace: string) => unknown>;
+      .EventSink<(changes: Record<string, {oldValue: unknown, newValue: unknown}>, namespace: string) => unknown>;
   local:
       {set<ResultT>(value: ResultT): void, get<ResultT>(keys: ResultT, callback: (result: ResultT) => unknown): void};
 }

extensions/cxx_debugging/src/DevToolsPluginHost.ts

@@ -651,7 +651,7 @@ export class ExtensionOptions extends HTMLElement {
     this.render();
   }
 
-  private updateConfigurations(data: {[key: string]: unknown}): void {
+  private updateConfigurations(data: Record<string, unknown>): void {
     if (this.timeoutId !== undefined) {
       window.clearTimeout(this.timeoutId);
     }
@@ -661,7 +661,7 @@ export class ExtensionOptions extends HTMLElement {
   }
 
   private render(): void {
-    const configurations = new Promise<{[key: string]: unknown}>(
+    const configurations = new Promise<Record<string, unknown>>(
         resolve => chrome.storage.local.get(
             {moduleConfigurations: DEFAULT_MODULE_CONFIGURATIONS, logPluginApiCalls: false}, resolve));
     const moduleConfigurationListPromise = configurations.then(

extensions/cxx_debugging/src/ExtensionOptions.ts

@@ -150,10 +150,11 @@ CustomFormatters.addFormatter({
 type CharArrayConstructor = Uint8ArrayConstructor|Uint16ArrayConstructor|Uint32ArrayConstructor;
 
 function formatRawString<T extends CharArrayConstructor>(
-    wasm: WasmInterface, value: Value, charType: T, decode: (chars: InstanceType<T>) => string): string|{
-  [key: string]: Value|null,
-}
-{
+    wasm: WasmInterface,
+    value: Value,
+    charType: T,
+    decode: (chars: InstanceType<T>) => string,
+    ): string|Record<string, Value|null> {
   const address = value.asUint32();
   if (address < Constants.SAFE_HEAP_START) {
     return formatPointerOrReference(wasm, value);
@@ -184,24 +185,15 @@ function formatRawString<T extends CharArrayConstructor>(
   return formatPointerOrReference(wasm, value);
 }
 
-export function formatCString(wasm: WasmInterface, value: Value): string|{
-  [key: string]: Value|null,
-}
-{
+export function formatCString(wasm: WasmInterface, value: Value): string|Record<string, Value|null> {
   return formatRawString(wasm, value, Uint8Array, str => new TextDecoder().decode(str));
 }
 
-export function formatU16CString(wasm: WasmInterface, value: Value): string|{
-  [key: string]: Value|null,
-}
-{
+export function formatU16CString(wasm: WasmInterface, value: Value): string|Record<string, Value|null> {
   return formatRawString(wasm, value, Uint16Array, str => new TextDecoder('utf-16le').decode(str));
 }
 
-export function formatCWString(wasm: WasmInterface, value: Value): string|{
-  [key: string]: Value|null,
-}
-{
+export function formatCWString(wasm: WasmInterface, value: Value): string|Record<string, Value|null> {
   // emscripten's wchar is 4 byte
   return formatRawString(wasm, value, Uint32Array, str => Array.from(str).map(v => String.fromCodePoint(v)).join(''));
 }
@@ -247,7 +239,7 @@ function reMatch(...exprs: RegExp[]): (type: TypeInfo) => boolean {
 
 CustomFormatters.addFormatter({types: reMatch(/^std::vector<.+>$/), format: formatVector});
 
-export function formatPointerOrReference(wasm: WasmInterface, value: Value): {[key: string]: Value|null} {
+export function formatPointerOrReference(wasm: WasmInterface, value: Value): Record<string, Value|null> {
   const address = value.asUint32();
   if (address === 0) {
     return {'0x0': null};
@@ -256,7 +248,7 @@ export function formatPointerOrReference(wasm: WasmInterface, value: Value): {[k
 }
 CustomFormatters.addFormatter({types: type => type.isPointer, format: formatPointerOrReference});
 
-export function formatDynamicArray(wasm: WasmInterface, value: Value): {[key: string]: Value|null} {
+export function formatDynamicArray(wasm: WasmInterface, value: Value): Record<string, Value|null> {
   return {[`0x${value.location.toString(16)}`]: value.$(0)};
 }
 CustomFormatters.addFormatter({types: reMatch(/^.+\[\]$/), format: formatDynamicArray});

extensions/cxx_debugging/src/Formatters.ts

@@ -172,7 +172,7 @@ export class TestValue implements Value {
     address = address ?? elements[0].location;
     content.setUint32(0, address, true);
     const space = elements[0].typeNames[0].endsWith('*') ? '' : ' ';
-    const members: {[key: string|number]: TestValue} = {'*': elements[0]};
+    const members: Record<string|number, TestValue> = {'*': elements[0]};
     for (let i = 0; i < elements.length; ++i) {
       members[i] = elements[i];
     }

extensions/cxx_debugging/tests/TestUtils.ts

@@ -587,7 +587,7 @@ describe('Color', () => {
   });
 
   it('retains and returns the authored text', () => {
-    const lime: {[key in Common.Color.Format]: string} = {
+    const lime: Record<Common.Color.Format, string> = {
       [Common.Color.Format.HEX]: '#00ff00',
       [Common.Color.Format.HEXA]: '#00ff00ff',
       [Common.Color.Format.RGB]: 'rgb(0 255 0)',

front_end/core/common/Color.test.ts

@@ -22,10 +22,8 @@ export function removeEventListeners(eventList: EventDescriptor[]): void {
 
 // This type can be used as the type parameter for `EventTarget`/`ObjectWrapper`
 // when the set of events is not known at compile time.
-export interface GenericEvents {
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  [eventName: string]: any;
-}
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export type GenericEvents = Record<string, any>;
 
 export type EventPayloadToRestParameters<Events, T extends keyof Events> = Events[T] extends void ? [] : [Events[T]];
 export type EventListener<Events, T extends keyof Events> = (arg0: EventTargetEvent<Events[T], Events>) => void;