Maintenance #3
Open
Maintenance #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| MIT License | ||
|
|
||
| Copyright (c) 2016 Philipp von Radziewsky | ||
| Copyright (c) 2016 AtomDebugger Team (Philipp von Radziewsky & Steel Brain) |
Member
Author
|
@philippvr Ping me on Atom Slack when you're on, got a few things to discuss about the codebase |
| export default { | ||
| instance: null, | ||
| activate() { | ||
| require('atom-package-deps').install('debugger') // eslint-disable-line |
Member
There was a problem hiding this comment.
The package shouldn't depend on itself.
Member
Author
There was a problem hiding this comment.
Well the package is not depending on itself 😉
It's just telling atom-package-deps the name of the current package to install dependencies of
Member
Author
There was a problem hiding this comment.
For more info, see https://github.com/steelbrain/package-deps#api
Member
There was a problem hiding this comment.
OK, I should check before making comments. 😊
Member
Author
There was a problem hiding this comment.
I appreciate the keen eye 😄
.eslintrc.json
Outdated
| { | ||
| "extends": "steelbrain", | ||
| "rules": { | ||
| "no-param-reassign": 0, |
This was referenced Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interface->decls